Github user ash211 commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/180#discussion_r10010480
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -71,10 +71,21 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
val computedValues = rdd.computeOrReadCheckpoint(split, context)
// Persist the result, so long as the task is not running locally
if (context.runningLocally) { return computedValues }
- val elements = new ArrayBuffer[Any]
- elements ++= computedValues
- blockManager.put(key, elements, storageLevel, tellMaster = true)
- elements.iterator.asInstanceOf[Iterator[T]]
+ if (storageLevel == StorageLevel.DISK_ONLY || storageLevel ==
StorageLevel.DISK_ONLY_2) {
--- End diff --
StorageLevels have .useDisk() and .useMemory() methods.
https://github.com/apache/incubator-spark/blob/master/core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
Maybe it makes sense to replace this with storageLevel.useDisk() &&
!storageLevel.useMemory()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
