As I recall I think we can merge envelope without affecting the existing code. But as you pointed out there are other gaps such as the UI. At this point I say merge as much as we can (assuming no obvious code quality issues) as any movement at this point is positive. If something breaks then we know what needs to be fixed.
- nathanael > On Mar 21, 2019, at 6:07 PM, Tadd Wood <[email protected]> wrote: > > Alan, > > I can help organize the open PRs. Right now the biggest barrier to merging > in the ODM branch is bridging the gap between the ingest code and the ODM. > @curtishoward did some great work in PR #144 using Envelope as the ingest > framework for populating the ODM. I will reach out to see what work is left > to finish up that PR so we can merge it in. > > Thank you, > Tadd Wood > > >> On Mar 21, 2019, at 4:02 PM, Alan Ross <[email protected]> wrote: >> >> thanks for the reply, Pierre-Luc. >> >> Any input on merging PRs? Is there a list of current open and which ones >> have been reviewed? >> >>> On Thu, Mar 21, 2019 at 1:10 PM Pierre-Luc Dion <[email protected]> wrote: >>> >>> Look like there few pending PR waiting to be merge to this branch, wouldn't >>> it make sense to merge all that first, then merge SPOT-181_odm branch into >>> master? >>> I'm not committer so I can't help on that but I can help with review >>> wherever it's possible. >>> >>> the PR pile look stalled, a lot of PR are becoming hold :-( >>> >>>> On Tue, Mar 19, 2019 at 4:59 PM Alan Ross <[email protected]> wrote: >>>> >>>> Hey team, >>>> >>>> It's hard for people to find the ODM as it appears to be tied up in >>> request >>>> 181. Can someone merge this? Not sure if we need to bring it for vote >>> but I >>>> support it being merged. >>>> >>>> >>>> >>> https://github.com/apache/incubator-spot/blob/SPOT-181_ODM/docs/open-data-model.md >>>> >>>> Thanks, Alan >>>> >>> >
