----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4584/#review6650 -----------------------------------------------------------
Thanks for the patch. Some comments below. src/java/org/apache/sqoop/manager/MySQLManager.java <https://reviews.apache.org/r/4584/#comment14346> Also need to use the tableName parameter here. src/java/org/apache/sqoop/manager/MySQLManager.java <https://reviews.apache.org/r/4584/#comment14347> Ditto. - Bilung On 2012-04-02 17:50:28, Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4584/ > ----------------------------------------------------------- > > (Updated 2012-04-02 17:50:28) > > > Review request for Sqoop. > > > Summary > ------- > > All-tables import fails with MySQL: > > https://issues.apache.org/jira/browse/SQOOP-473 > > The change include: > > 1) Modify toJavaType(), toHiveType(), and toAvroType() methods. > 2) Add new unit test for MySQL all-tables import (subclassing TestAllTables). > 3) Minor changes to TestAllTables class to make it available for non-Hsqldb > servers. > > > This addresses bug SQOOP-473. > https://issues.apache.org/jira/browse/SQOOP-473 > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/TableDefWriter.java bfac391 > src/java/org/apache/sqoop/manager/ConnManager.java 26a2a82 > src/java/org/apache/sqoop/manager/MySQLManager.java 3254a2c > src/java/org/apache/sqoop/manager/OracleManager.java 30401c5 > src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java a7ea834 > src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java ff39801 > src/java/org/apache/sqoop/orm/ClassWriter.java 986934d > src/test/com/cloudera/sqoop/TestAllTables.java e6561e9 > src/test/com/cloudera/sqoop/manager/MySQLAllTablesTest.java e69de29 > > Diff: https://reviews.apache.org/r/4584/diff > > > Testing > ------- > > 1) Verified that MySQL all-tables import is fixed using new unit test. > 2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle. > > > Thanks, > > Cheolsoo > >
