[
https://issues.apache.org/jira/browse/SQOOP-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261615#comment-13261615
]
[email protected] commented on SQOOP-453:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4858/#review7212
-----------------------------------------------------------
Ship it!
Hi Cheolsoo,
change seems fine to me. I've noticed that you've already attached patch to the
JIRA, so I'll commit it shortly.
Jarcec
- Jarek
On 2012-04-24 20:26:31, Cheolsoo Park wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4858/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 20:26:31)
bq.
bq.
bq. Review request for Sqoop, Jarek Cecho and Kathleen Ting.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Sqoop metastore jobs cannot be launched via Oozie when
sqoop.metastore.client.record.password disabled.
bq.
bq. The changes include:
bq. 1) Print out informative error message.
bq. 2) Add a note to user doc.
bq.
bq.
bq. This addresses bug SQOOP-453.
bq. https://issues.apache.org/jira/browse/SQOOP-453
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/docs/user/saved-jobs.txt 1329854
bq. /src/java/org/apache/sqoop/SqoopOptions.java 1329854
bq.
bq. Diff: https://reviews.apache.org/r/4858/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manually verified the following cases:
bq.
bq. 1) sqoop.metastore.client.record.password = false && --password is NOT
given in the command tag
bq. => Jobs fail with the error message in task logs.
bq.
bq. 2) sqoop.metastore.client.record.password = false && --password is given
in the command tag
bq. => Jobs succeed.
bq.
bq. 3) sqoop.metastore.client.record.password = true
bq. => Jobs succeed.
bq.
bq. I also ran ant test and ant checkstyle.
bq.
bq.
bq. Thanks,
bq.
bq. Cheolsoo
bq.
bq.
> Oozie does not work with Sqoop metastore
> ----------------------------------------
>
> Key: SQOOP-453
> URL: https://issues.apache.org/jira/browse/SQOOP-453
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Patrick Angeles
> Assignee: Cheolsoo Park
> Attachments: SQOOP-453.patch
>
>
> The sqoop metastore is handy for retaining lastvalue during incremental
> imports.
> Unfortunately, it does not work with Oozie. Here's the log from the launcher:
> java.lang.NullPointerException
> at
> com.cloudera.sqoop.SqoopOptions.securePasswordEntry(SqoopOptions.java:1069)
> at
> com.cloudera.sqoop.SqoopOptions.setPasswordFromConsole(SqoopOptions.java:1077)
> at com.cloudera.sqoop.SqoopOptions.loadProperties(SqoopOptions.java:562)
> at
> com.cloudera.sqoop.metastore.hsqldb.HsqldbJobStorage.read(HsqldbJobStorage.java:303)
> at com.cloudera.sqoop.tool.JobTool.execJob(JobTool.java:203)
> at com.cloudera.sqoop.tool.JobTool.run(JobTool.java:288)
> at com.cloudera.sqoop.Sqoop.run(Sqoop.java:146)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
> at com.cloudera.sqoop.Sqoop.runSqoop(Sqoop.java:182)
> at com.cloudera.sqoop.Sqoop.runTool(Sqoop.java:221)
> at com.cloudera.sqoop.Sqoop.runTool(Sqoop.java:230)
> at com.cloudera.sqoop.Sqoop.main(Sqoop.java:239)
> at
> org.apache.oozie.action.hadoop.SqoopMain.runSqoopJob(SqoopMain.java:198)
> at org.apache.oozie.action.hadoop.SqoopMain.run(SqoopMain.java:172)
> at org.apache.oozie.action.hadoop.LauncherMain.run(LauncherMain.java:26)
> at org.apache.oozie.action.hadoop.SqoopMain.main(SqoopMain.java:43)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.apache.oozie.action.hadoop.LauncherMapper.map(LauncherMapper.java:391)
> at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:50)
> at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:391)
> at org.apache.hadoop.mapred.MapTask.run(MapTask.java:325)
> at org.apache.hadoop.mapred.Child$4.run(Child.java:270)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1157)
> at org.apache.hadoop.mapred.Child.main(Child.java:264)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
