[ 
https://issues.apache.org/jira/browse/SQOOP-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271915#comment-13271915
 ] 

[email protected] commented on SQOOP-484:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5065/#review7751
-----------------------------------------------------------


Jarcec - good work. Some feedback.
1.) "This is because by default MySQL" needs a 'the', i.e. "This is because by 
default the MySQL"
2.) How about "A more clean solution" instead of "Most cleaner solution"? 
3.) How about expanding on "Another solution would be to use sqoop ability to 
override default mapping." - e.g. Another solution would be to explicitly 
override the column mapping for the datatype TINYINT(1) column. For example, if 
the column name is foo, then pass the following option to Sqoop during import: 
--map-column-hive foo=tinyint. In the case of non-Hive imports to HDFS, use 
--map-column-java foo=integer.

- Kathleen


On 2012-05-08 11:21:33, Jarek Cecho wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/5065/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-08 11:21:33)
bq.  
bq.  
bq.  Review request for Sqoop and Kathleen Ting.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  I've updated corresponding section in Troubleshooting guide.
bq.  
bq.  
bq.  This addresses bug SQOOP-484.
bq.      https://issues.apache.org/jira/browse/SQOOP-484
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/docs/user/troubleshooting.txt 1335407 
bq.  
bq.  Diff: https://reviews.apache.org/r/5065/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jarek
bq.  
bq.


                
> Update troubleshooting guide section about MySQL and TINYINT(1) columns
> -----------------------------------------------------------------------
>
>                 Key: SQOOP-484
>                 URL: https://issues.apache.org/jira/browse/SQOOP-484
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: docs
>    Affects Versions: 1.4.1-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Trivial
>             Fix For: 1.4.2-incubating
>
>         Attachments: SQOOP-484.patch
>
>
> This issue is continuation of JIRA ticket SQOOP-463. 
> I've investigated MySQL JDBC connector behavior in case of columns defined as 
> TINYINT(1). By default MySQL JDBC connector is converting TINYINT(1) into 
> java.sql.Types.BIT, which can be very easily turned off by specifying 
> tinyInt1isBit=false in JDBC path. For example 
> jdbc:mysql://localhost/test?tinyInt1isBit=false. I would suggest to update 
> troubleshooting guide by suggesting users to set this property rather than 
> overriding default sqoop type mapping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to