----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5432/#review8429 -----------------------------------------------------------
One comment below. /src/java/org/apache/sqoop/ConnFactory.java <https://reviews.apache.org/r/5432/#comment18109> The code here doesn't handle the case with "=" in the path (which may not be that common though). It may be better to get the key-value pair simply based on the first appearance of "=". - Bilung Lee On June 20, 2012, 7:17 p.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5432/ > ----------------------------------------------------------- > > (Updated June 20, 2012, 7:17 p.m.) > > > Review request for Sqoop, Jarek Cecho and Bilung Lee. > > > Description > ------- > > Whitespace should be trimmed when the property file is loaded. > > > This addresses bug SQOOP-505. > https://issues.apache.org/jira/browse/SQOOP-505 > > > Diffs > ----- > > /src/java/org/apache/sqoop/ConnFactory.java 1351937 > > Diff: https://reviews.apache.org/r/5432/diff/ > > > Testing > ------- > > 1) ant test, ant test -Dthirdparty=true, and ant checkstyle. > > 2) Tested using Teradata connector with the following 'connector' file: > > <some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some > space>=<some > space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some > space> > > > Thanks, > > Cheolsoo Park > >
