----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5452/#review8666 -----------------------------------------------------------
Ship it! Ship It! - Bilung Lee On June 27, 2012, 6:21 p.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5452/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 6:21 p.m.) > > > Review request for Sqoop, Bilung Lee and Jarek Cecho. > > > Description > ------- > > We should print a better error message when a connector file contains any > lines that are not in the form of key=value. > > > This addresses bug SQOOP-510. > https://issues.apache.org/jira/browse/SQOOP-510 > > > Diffs > ----- > > /src/java/org/apache/sqoop/ConnFactory.java 1354622 > > Diff: https://reviews.apache.org/r/5452/diff/ > > > Testing > ------- > > Tested with a bad connector file and verified the following error is printed: > > 12/06/26 07:32:09 ERROR sqoop.ConnFactory: Error loading ManagerFactory > information from file > /home/cheolsoo/workspace/sqoop_510/bin/../conf/managers.d/mssqoop-sqlserver: > java.io.IOException: the content of connector file must be in form of > key=value > > > Thanks, > > Cheolsoo Park > >
