> On June 29, 2012, 6:28 p.m., Bilung Lee wrote: > > Some comments/suggestions below:
Thank you very much for reviewing my patch! I guess that I will have to take out expectj then. There is another one called "expect4j" that is under apache license; however, it is not on the maven repository. I will do more search. I agree with your other suggestions. Let me incorporate them in a new patch. - Cheolsoo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5626/#review8720 ----------------------------------------------------------- On June 28, 2012, 1:14 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5626/ > ----------------------------------------------------------- > > (Updated June 28, 2012, 1:14 a.m.) > > > Review request for Sqoop and Bilung Lee. > > > Description > ------- > > If a command does not have full options specified, instead of displaying full > help, the shell could get into an interactive session to gather the options > one by one from the user. > > > This addresses bug SQOOP-494. > https://issues.apache.org/jira/browse/SQOOP-494 > > > Diffs > ----- > > /branches/sqoop2/client/pom.xml 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java > 1354162 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/interactivesession/MultiChoiceQuestion.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/interactivesession/Question.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/interactivesession/ShortAnswerQuestion.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/interactivesession/YesNoQuestion.java > PRE-CREATION > > /branches/sqoop2/client/src/test/java/org/apache/sqoop/client/TestInteractiveSession.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5626/diff/ > > > Testing > ------- > > Added two unit tests for "set server" and "show server". > > > Thanks, > > Cheolsoo Park > >
