----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6018/#review9239 -----------------------------------------------------------
Ship it! Hi Arvind, you're changes looks good to me. There is just couple lines with trailing spaces, would you mind removing them? /branches/sqoop2/dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/6018/#comment19791> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/6018/#comment19792> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/6018/#comment19793> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/6018/#comment19794> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/6018/#comment19795> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop_bootstrap.properties <https://reviews.apache.org/r/6018/#comment19796> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop_bootstrap.properties <https://reviews.apache.org/r/6018/#comment19797> Trailing spaces /branches/sqoop2/dist/src/main/server/conf/sqoop_bootstrap.properties <https://reviews.apache.org/r/6018/#comment19798> Trailing spaces Jarcec - Jarek Cecho On July 17, 2012, 7:27 p.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6018/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 7:27 p.m.) > > > Review request for Sqoop and Bilung Lee. > > > Description > ------- > > The original Jira was about creating a top-level configuration directory, but > one already exists under dist/src/main directory. I have therefore added the > comments to the configuration files present in this directory. > > > This addresses bug SQOOP-491. > https://issues.apache.org/jira/browse/SQOOP-491 > > > Diffs > ----- > > /branches/sqoop2/dist/src/main/server/conf/sqoop.properties 1362585 > /branches/sqoop2/dist/src/main/server/conf/sqoop_bootstrap.properties > 1362585 > > Diff: https://reviews.apache.org/r/6018/diff/ > > > Testing > ------- > > Built the system and verified that the configuration files were present in > generated dist tarball. > > > Thanks, > > Arvind Prabhakar > >
