> On Aug. 2, 2012, 9:48 p.m., Bilung Lee wrote: > > /src/java/org/apache/sqoop/ConnFactory.java, line 128 > > <https://reviews.apache.org/r/6250/diff/2/?file=132307#file132307line128> > > > > One nit: add a space before the word "Sqoop".
Thanks for your review sir, I've uploaded updated patch to JIRA, feel free to commit it at will. Jarcec - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6250/#review9788 ----------------------------------------------------------- On Aug. 1, 2012, 4:03 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6250/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2012, 4:03 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've refactored the code in the way I've designed in the JIRA. > > > This addresses bug SQOOP-529. > https://issues.apache.org/jira/browse/SQOOP-529 > > > Diffs > ----- > > /src/java/org/apache/sqoop/ConnFactory.java 1367605 > /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 1367605 > > Diff: https://reviews.apache.org/r/6250/diff/ > > > Testing > ------- > > ant tests passes > > > Thanks, > > Jarek Cecho > >
