----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5344/#review9836 -----------------------------------------------------------
Ship it! Looks good to me. Jarcec - Jarek Cecho On Aug. 3, 2012, 6:52 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5344/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 6:52 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > Blob import fails because byte[] is not mapped to avro bytes type. Wrapping > byte[] as ByteBuffer fixes the problem. > > > This addresses bug SQOOP-536. > https://issues.apache.org/jira/browse/SQOOP-536 > > > Diffs > ----- > > /src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1368365 > > Diff: https://reviews.apache.org/r/5344/diff/ > > > Testing > ------- > > I verified with avro 1.5.3 (current) and 1.7.1 that the unit tests pass: > > ant test > ant test -Dthirdparty=true > ant checkstyle > > > Thanks, > > Cheolsoo Park > >
