----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5644/#review10310 -----------------------------------------------------------
Ship it! The proposal looks good to me sir. Please attach the patch to JIRA and I'll commit. - Jarek Cecho On Aug. 14, 2012, 5:28 p.m., Bilung Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5644/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 5:28 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Define interfaces for connector-defined classes within the job execution > lifecycle. > > > This addresses bug SQOOP-532. > https://issues.apache.org/jira/browse/SQOOP-532 > > > Diffs > ----- > > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java > 1372967 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java > PRE-CREATION > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java > 1372967 > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Context.java > PRE-CREATION > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java > 1372967 > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java > 1372967 > > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java > 1372967 > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java > 1372967 > > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/MutableContext.java > PRE-CREATION > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partition.java > PRE-CREATION > > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java > 1372967 > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataReader.java > PRE-CREATION > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataWriter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5644/diff/ > > > Testing > ------- > > > Thanks, > > Bilung Lee > >
