[
https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438114#comment-13438114
]
Seetharam Venkatesh commented on SQOOP-580:
-------------------------------------------
bq. Moving those methods to JobBase make sense to me as it seems as unnecessary
code repetition.
I thought of this as well but if you look at the exceptions, they are
different.
ImportJobBase throws ImportException while ExportJobBase throws ExportException
apart from IOException. I could very well wrap these into IOException but there
is an implementation in org.apache.sqoop.mapreduce.HBaseImportJob that uses the
specific ImportException and wanted to leave it in there.
Makes sense?
Any thoughts on eliminating repetition are welcome.
> Add Open-ended "teardown" routine that is called after the job execution for
> cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just
> before it is submitted to MapReduce. I'm adding a jobTeardown method in the
> finally block.
> I think the same applies to
> org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called
> there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
