[ 
https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438125#comment-13438125
 ] 

Seetharam Venkatesh commented on SQOOP-582:
-------------------------------------------

Well, you need to look at the implementations carefully to observe that it is 
necessary to duplicate the code. The runJob in itself is a template method that 
is overridden by Import and Export and the counter read by each of these are 
different.

I could copy the doSubmitJob method to the base class but using it in runJob 
does not make sense IMO. Do you prefer the former?
                
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
>                 Key: SQOOP-582
>                 URL: https://issues.apache.org/jira/browse/SQOOP-582
>             Project: Sqoop
>          Issue Type: Bug
>          Components: connectors
>    Affects Versions: 1.4.1-incubating
>            Reporter: Seetharam Venkatesh
>            Assignee: Seetharam Venkatesh
>            Priority: Minor
>         Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. 
> There are use cases when a connector needs to submit job and do other things 
> while the job is in progress retaining the code to extract counters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to