----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6951/#review11169 -----------------------------------------------------------
Ship it! Thanks for the patch. Look good overall. One file is missing license header though as indicated below. I will got ahead and commit the patch with license header added. Could you also update the JIRA with a new patch for the record. /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java <https://reviews.apache.org/r/6951/#comment23888> Need the license header here. - Bilung Lee On Sept. 7, 2012, 6:58 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6951/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 6:58 a.m.) > > > Review request for Sqoop and Bilung Lee. > > > Description > ------- > > This is huge patch that is implementing logic for entire connection resource. > I'm sorry that I did not split it up into smaller chunks - I was heavily > prototyping during the development and thus I did not had independent parts > that could be uploaded. > > I'm very open to any suggestions or improvements. > > > This addresses bug SQOOP-596. > https://issues.apache.org/jira/browse/SQOOP-596 > > > Diffs > ----- > > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/core/ClientError.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/display/FormDisplayer.java > 1381185 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/ConnectorRequest.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/FrameworkRequest.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/Request.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/VersionRequest.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java > 1381544 > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java > PRE-CREATION > > /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/common/ExceptionInfo.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectionBean.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ExceptionInfo.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/FrameworkBean.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ValidationBean.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnection.java > 1381185 > /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MInput.java > 1381185 > /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MMapInput.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MStringInput.java > 1381185 > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java > PRE-CREATION > > /branches/sqoop2/common/src/main/java/org/apache/sqoop/validation/Status.java > PRE-CREATION > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java > PRE-CREATION > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java > 1381185 > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java > 1381185 > /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestUtil.java > PRE-CREATION > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestValidationBean.java > PRE-CREATION > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/utils/TestMapResourceBundle.java > PRE-CREATION > > /branches/sqoop2/common/src/test/java/org/apache/sqoop/validation/TestStatus.java > PRE-CREATION > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 1381185 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java > 1381185 > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java > PRE-CREATION > > /branches/sqoop2/connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties > 1381185 > > /branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/Repository.java > 1381185 > > /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/RepositoryError.java > 1381185 > /branches/sqoop2/core/src/main/resources/framework-resources.properties > PRE-CREATION > > /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > 1381185 > > /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 1381185 > > /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 1381185 > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > PRE-CREATION > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 1381185 > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java > 1381185 > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/RequestContext.java > 1381185 > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java > 1381185 > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/common/ServerError.java > PRE-CREATION > > /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/v1/ConnectionServlet.java > PRE-CREATION > /branches/sqoop2/server/src/main/webapp/WEB-INF/web.xml 1381185 > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/validation/Status.java > 1381185 > > /branches/sqoop2/spi/src/main/java/org/apache/sqoop/validation/Validator.java > 1381185 > > Diff: https://reviews.apache.org/r/6951/diff/ > > > Testing > ------- > > Very few test cases are added, I'll add more later. > > > Thanks, > > Jarek Cecho > >
