----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7193/#review11744 -----------------------------------------------------------
Ship it! Hi Jarcec, thank you for the clarification. Indeed, the other split() method converts (0, 1, 1) to [0, 1) and [1, 1]. Now I see why you want this change. I no longer have questions. - Cheolsoo Park On Sept. 20, 2012, 3:37 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7193/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2012, 3:37 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've decided to alter method split() to add one maxVal in case that there is > less or equal split points then requested split count. > > > This addresses bug SQOOP-603. > https://issues.apache.org/jira/browse/SQOOP-603 > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 35b74eb > src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 8e7a096 > src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java 22d5140 > > Diff: https://reviews.apache.org/r/7193/diff/ > > > Testing > ------- > > * ant test > * Real MySQL instance in couple of scenarios > > > Thanks, > > Jarek Cecho > >
