----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7409/#review12258 -----------------------------------------------------------
Ship it! Ship It! - Bilung Lee On Oct. 9, 2012, 1:17 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7409/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2012, 1:17 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > This patch removes cca 200 FindBugs warning and errors. > > > This addresses bug SQOOP-618. > https://issues.apache.org/jira/browse/SQOOP-618 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/Environment.java 2afd0f7 > client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java ee38407 > client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java > 02588c7 > client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 4e58a34 > common/src/main/java/org/apache/sqoop/common/ErrorCode.java f53d972 > common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java > b06e059 > common/src/main/java/org/apache/sqoop/common/VersionInfo.java 02f8cf3 > common/src/main/java/org/apache/sqoop/json/JsonBean.java aa84935 > common/src/main/java/org/apache/sqoop/json/ValidationBean.java 6883a85 > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > 752acbe > > common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java > dc4aac3 > common/src/main/java/org/apache/sqoop/model/MConnection.java 97771a3 > common/src/main/java/org/apache/sqoop/model/MJob.java 186716a > common/src/main/java/org/apache/sqoop/model/MMapInput.java 9818d71 > common/src/main/java/org/apache/sqoop/model/MValidatedElement.java a0c5074 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > b1367ed > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 8dc3704 > core/src/main/java/org/apache/sqoop/core/ConfigurationListener.java e106043 > core/src/main/java/org/apache/sqoop/core/ConfigurationProvider.java 3dcb853 > > core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java > 8837dc9 > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 3d84d4a > core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java > eb6e8b2 > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 4485fd6 > core/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java > ad513e1 > core/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java > 1368a5e > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java be23ebf > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java > dc01d89 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > aaca7f7 > > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.java > 96c75be > core/src/main/java/org/apache/sqoop/repository/Repository.java 5580b4e > core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java > 17c81a1 > core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java > 7326536 > core/src/main/java/org/apache/sqoop/repository/RepositoryTransaction.java > d86d79b > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 4d7c3fc > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > 49c93b4 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > b8dc3b8 > server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java > 9a60c63 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 6fbf47c > server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java > 75c36d8 > server/src/main/java/org/apache/sqoop/server/RequestContext.java 90e174e > server/src/main/java/org/apache/sqoop/server/RequestHandler.java 43d98c5 > server/src/main/java/org/apache/sqoop/server/ServerInitializer.java cd2b13e > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > b452bc3 > spi/src/main/java/org/apache/sqoop/job/etl/Context.java 7256281 > spi/src/main/java/org/apache/sqoop/job/etl/MutableContext.java 2bfe89f > > Diff: https://reviews.apache.org/r/7409/diff/ > > > Testing > ------- > > * mvn test > * Manual CRUD test for connection and job objects > > > Thanks, > > Jarek Cecho > >
