----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7558/#review12521 -----------------------------------------------------------
Ship it! Ship It! - Bilung Lee On Oct. 11, 2012, 11:13 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7558/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 11:13 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > This patch includes several changes: > > * Forms are substituted with configuration objects (that are properly > annotated) on connector level. Other parts of Sqoop are still dealing with > forms (repository, server, client). I'll start removing forms from other > sections as well. I'm not sure that we can completely get rid of the forms as > we still need them on client side where we do not have access to connector > specific configuration classes. > * I've disabled MySQL connectors > * I've refactored most of the client code by abstracting all request related > code to one single class that is acting as a cache. > > > This addresses bug SQOOP-627. > https://issues.apache.org/jira/browse/SQOOP-627 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/RequestCache.java > PRE-CREATION > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > 80a84cd2b25860cf8a6e0777e5c5ebcfaa655e88 > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > b93e40712962c9db6cefee893f209dd46734abd2 > > client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java > eac23c6cb8578cc043e5ef9d0a8c1d6fa2431ef6 > client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java > 536b7f3912160ff6bb2f802ea1178a6683196780 > > client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java > f35ba5b1fd5846bbe0f3526cc6012d743150fb6b > client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java > 41f43a3a4bff0b58ec9ff1ec5e57b31060aa3399 > > client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java > 43a40028f261082c02d6be78bed1fb3e59934ae9 > client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java > 08f37d8855d4371a78e55acc01551acc2698c978 > > client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java > a499ff8ff4253231dbedecbcc5f109f449db9f81 > > client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java > 07c9c56e5edb0444fe85dc82d45eb140dca71295 > > client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java > 532ff04cf2627a06aa399f96550e4f99c13572f4 > client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java > 19b11cc43fbabd78f8dc39b170c6cafb8e648bb4 > > client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java > 64604f17dd2bca84482dd709a8391b58a661770b > client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java > ee387fdfb75602549a69b8e7e2fbd74127e49e29 > client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java > df3929163f30927806a0d6882a7aaeef42e6b6e8 > common/src/main/java/org/apache/sqoop/json/ValidationBean.java > 8b8de727558b97b34ed653a81ef9d0eece825803 > common/src/main/java/org/apache/sqoop/model/Configuration.java PRE-CREATION > common/src/main/java/org/apache/sqoop/model/FormUtils.java PRE-CREATION > common/src/main/java/org/apache/sqoop/model/Input.java PRE-CREATION > common/src/main/java/org/apache/sqoop/model/MValidatedElement.java > ce8f2cdbe6e13d52fd0ab04bac70eaccac95bfc2 > common/src/main/java/org/apache/sqoop/model/ModelError.java > 7a9ebd89423b422830e4c2baad03382bc596097b > common/src/main/java/org/apache/sqoop/utils/ClassLoadingUtils.java > a7a870f90180115b0d7a699c2b7995d96e36c763 > common/src/main/java/org/apache/sqoop/validation/Status.java > 5c9fb9c049e36287e18fd37c6b6e21ef2e59616a > common/src/main/java/org/apache/sqoop/validation/Validation.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/validation/ValidationError.java > PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestValidationBean.java > 738b4e51a17fba7a8d3814eb74acabe6ce3ca143 > common/src/test/java/org/apache/sqoop/model/TestFormUtils.java PRE-CREATION > common/src/test/java/org/apache/sqoop/utils/TestClassLoadingUtils.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 14f216cc6f3c4c55c724e6565237e4d689ff5fa2 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java > f73f76ecf7f9159f7433272fdd0972f22862131a > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties > 8f9aa6061d846690f98e9f1b0fa02ed696eaba3f > connector/connector-mysql-jdbc/src/main/resources/sqoopconnector.properties > 89c4b1cd7387d7bf646f36ea6a00a8c6b7587fb8 > connector/pom.xml d3b3ec8fe4d4536f9949ae39d20e6fa23fe86932 > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java > 8014be1baec03af0e0a2a69746d3a37fae571bcf > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java > 41269df249d14b394f6f63f777cf2b891845356d > > core/src/main/java/org/apache/sqoop/framework/configuration/ConnectionConfiguration.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java > PRE-CREATION > core/src/main/resources/framework-resources.properties > 577b7aa4e9befc02c7fe4b380d0d37a9d2f20407 > server/pom.xml 91c37c410a6891c2d221340177da9cc10044b5fd > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java > 509e3db4c0df5488ca0257c2ff3f9192e561569a > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 066e42db29616b0b05b1ebe1bfe2e8acbc73ab7c > spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > b56c331a44c6dc2ef3563f78f15228fe7cb7fdd5 > spi/src/main/java/org/apache/sqoop/validation/Validator.java > 185efd33a4840fb79ebae6ff3dfa8e72635240e9 > > Diff: https://reviews.apache.org/r/7558/diff/ > > > Testing > ------- > > * I've provided unit tests for new main functionally > * I've done live testing (CRUD with jobs and connections) > > > Thanks, > > Jarek Cecho > >
