----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7828/#review13055 -----------------------------------------------------------
Ship it! Hi Cheolsoo, thank you very much for incorporating all my suggestions and please accept my apology for so many rounds. - Jarek Cecho On Nov. 2, 2012, 1:19 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7828/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2012, 1:19 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > Re-based my old patch to trunk. > > > This addresses bug SQOOP-467. > https://issues.apache.org/jira/browse/SQOOP-467 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/MySQLManager.java a3f586a > src/java/org/apache/sqoop/manager/OracleManager.java 6974e1b > src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 309a960 > > Diff: https://reviews.apache.org/r/7828/diff/ > > > Testing > ------- > > ant test > ant test -Dthridparty=true > > I added two test cases - one for BINARY_FLOAT and one for BINARY_DOUBLE - to > the OracleCompatTest suite. > > > Thanks, > > Cheolsoo Park > >
