----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7779/#review13070 -----------------------------------------------------------
Ship it! Hi Bilung, your changes looks good to me. Please accept my apologies for the test case commenting. Please upload your patch to the JIRA and I'll commit it. Jarec - Jarek Cecho On Nov. 3, 2012, 12:59 a.m., Bilung Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7779/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2012, 12:59 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Develop initializer and loader for export path of generic JDBC conntector. > (Test cases are still yet to be enabled to accommodate the changes in > SQOOP-656) > > > This addresses bug SQOOP-655. > https://issues.apache.org/jira/browse/SQOOP-655 > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/common/MapContext.java c1d24ad > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > 226fcd3 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java > c230f01 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java > 0e91767 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java > 4cf0595 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java > 3f6718d > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java > 2075d99 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java > 5071471 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java > PRE-CREATION > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java > PRE-CREATION > spi/src/main/java/org/apache/sqoop/job/Constants.java 927950d > spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 37b9f1b > spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 2092815 > > Diff: https://reviews.apache.org/r/7779/diff/ > > > Testing > ------- > > > Thanks, > > Bilung Lee > >
