-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7881/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 1:14 a.m.)


Review request for Sqoop.


Changes
-------

That's an excellent catch sir, thank you very much! Obviously my IDE did not 
move the class correctly and I've missed it. Thanks again!

Jarcec


Description
-------

I've abstracted execution engine to it's own module so that sqoop-core do no 
longer have dependencies on hadoop libraries. This patch seems more heavier 
than it actually is because I was moving a lot of files around - I however did 
not made any changes to them.


This addresses bug SQOOP-666.
    https://issues.apache.org/jira/browse/SQOOP-666


Diffs (updated)
-----

  core/pom.xml 028c24063ffa6cd3324c83ca02d051dae7363f41 
  core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java 
PRE-CREATION 
  core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java 
d6e70ca70b019a5d75abdfcb98c0d0a0390d63fc 
  core/src/main/java/org/apache/sqoop/framework/FrameworkError.java 
19d0d8757dcc2928cf3a001dd5a46bc05ab2c189 
  core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 
604d403d4e634cac51bccd0ea7aa09fc462d387e 
  core/src/main/java/org/apache/sqoop/framework/SubmissionEngine.java 
f4ad3f5a12e0871362a44832f668d554b00b4a3d 
  core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java 
27b0566c274819d5a1c131fea26a751d3099161d 
  core/src/main/java/org/apache/sqoop/job/JobConstants.java 
19ac91e00ad92f6b17bd6e210c1b8e293e8f2960 
  core/src/main/java/org/apache/sqoop/job/PrefixContext.java 
5488b46f87dabff874e4a2da6d1b8c7a711072f2 
  core/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java 
1235d1d90e14c35ac898f9d4dca0f969b561e47e 
  core/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java 
36aa11f7f2871e99fbc84d518bfa524d108f3cf4 
  core/src/main/java/org/apache/sqoop/job/io/Data.java 
4ddd13209e4b581d32fc46508826e7e40683b3ee 
  core/src/main/java/org/apache/sqoop/job/io/FieldTypes.java 
e96dc6e2f414841fba7c4dc49fe9b0ba9a0b18a1 
  core/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 
59baaf688cf9af5ff4562335f75e97fd114c5b85 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java 
c465f10113b8c1170336bb41ba2ad7244c58ede4 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 
8fcdc99daa08a02775ed2ba0708eccfdfdbe078b 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 
6892b4b5f48ada17185ca2bd170a8af3d87483db 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 
1242f90c8de4f267509592abf15195085151bab2 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 
96e1533ec1899f618b5a49c7a4fabac1abbb541a 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java 
d2361482771eea1a34b14c767952c5592f89c45a 
  core/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java 
7dc9541350a85e4178975b45e97619f99d1aa509 
  core/src/test/java/org/apache/sqoop/io/TestData.java 
9fe9d4130c4c45f8d2909f2cd4213a22dac8f8d9 
  core/src/test/java/org/apache/sqoop/job/FileUtils.java 
e685883e9c540c06723d1927d52ddfc0073b3fae 
  core/src/test/java/org/apache/sqoop/job/JobUtils.java 
e6ead3f265d43b7a9797461c2bed804102a562ef 
  core/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 
c74faa2bbaf9ea808e69b02a0b42f16469e17322 
  core/src/test/java/org/apache/sqoop/job/TestJobEngine.java 
51dddb42e3840ffa7b64f186d83b71ea848b9a10 
  core/src/test/java/org/apache/sqoop/job/TestMapReduce.java 
94ab560490cff8ccbfc24950c76ea3cb485ba37a 
  dist/src/main/server/conf/sqoop.properties 
d429c3a8d000819d2ed6e6a8e91405c3937606a7 
  execution/mapreduce/pom.xml PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MRSubmissionRequest.java
 PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
 PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 
PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/PrefixContext.java 
PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java
 PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java
 PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 
PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/FieldTypes.java 
PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
 PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java
 PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 
PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 
PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java
 PRE-CREATION 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
 PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java 
PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/FileUtils.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestJobEngine.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 
PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 
PRE-CREATION 
  execution/pom.xml PRE-CREATION 
  pom.xml a4915fd6318884f1c1eadf95c734b2f24371d223 
  submission/mapreduce/pom.xml 03c06c0d5e0ce3482dddec57b66417c9cfb9115f 
  
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
 704992456ddb27f32c23b49b204f9d5406416409 

Diff: https://reviews.apache.org/r/7881/diff/


Testing
-------

* "mvn clean verify compile test package" works
* I've tested it on my testing box


Thanks,

Jarek Cecho

Reply via email to