----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8131/#review13601 -----------------------------------------------------------
Ship it! One nit is that you may want to rename the patch to "SQOOP-714.patch" (from current name "SQOOP-712.patch"). - Bilung Lee On Nov. 19, 2012, 11:03 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8131/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 11:03 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've chanced all mapreduce related code so that Sqoop 2 will compile against > Hadoop 1. Please note that this patch do not make much sense without > SQOOP-713. > > > This addresses bug SQOOP-714. > https://issues.apache.org/jira/browse/SQOOP-714 > > > Diffs > ----- > > execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java > 58b2a42 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java > 7c0ef08 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java > c465f10 > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > e6ead3f > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java > 2287b06 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 3e498ec > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 48dc073 > > Diff: https://reviews.apache.org/r/8131/diff/ > > > Testing > ------- > > Unit tests seems to be passing and I've tested the code on Hadoop 2 based map > reduce cluster. > > > Thanks, > > Jarek Cecho > >
