[ 
https://issues.apache.org/jira/browse/SQOOP-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528023#comment-13528023
 ] 

Jarek Jarcec Cecho commented on SQOOP-652:
------------------------------------------

Hi Linden, 
your patch is excellent! Thank you very much for your time and effort. Would 
you mind just tweaking the exception ending little bit? I would propose 
something like:

{code}
...or lower the number of mappers to 1. Unknown SQL data type:" + sqlDataType);
{code}

My motivation is that current exception will simply generate something like 
following line:

{code}
...or lower the number of mappers to 1. -1
{code}

I'm afraid that the "random" number at the end might confuse our users.

Jarcec


                
> Improve error message generated in  DataDrivenDBInputFormat when no splitter 
> is available
> -----------------------------------------------------------------------------------------
>
>                 Key: SQOOP-652
>                 URL: https://issues.apache.org/jira/browse/SQOOP-652
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Linden Hillenbrand
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.4.3
>
>         Attachments: DataDrivenDBInputFormat.patch
>
>
> Currently DataDrivenDBInputFormat will throw following exception in case that 
> there is no available Splitter:
> {code}
> DBSplitter splitter = getSplitter(sqlDataType);
> if (null == splitter) {
>   throw new IOException("Unknown SQL data type: " + sqlDataType);
> }
> {code}
> Text of the exception is very confusing as it's not describing what has 
> actually happened. Would be great if this message would be improved by saying 
> that Sqoop do not have splitter for given sql type and therefore user should 
> either use different split column (argument --split-by) or lower number of 
> mappers to 1 (splitters are not used in such case).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to