----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8542/#review14351 -----------------------------------------------------------
Ship it! Hi Hari, thank you very much for fixing this nasty bug and finding yet another blocker! I've tested import on real cluster and it seems to be working fine, so I'll go ahead and commit it. - Jarek Cecho On Dec. 12, 2012, 6:58 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8542/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 6:58 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Threading updates to make sure close returns only after the consumer thread > completes, so that any asynchronous close/flush complete. > > > This addresses bug SQOOP-738. > https://issues.apache.org/jira/browse/SQOOP-738 > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > 71b4724 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java > 9edf0ba > > Diff: https://reviews.apache.org/r/8542/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
