----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8657/#review14631 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Dec. 18, 2012, 1:54 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8657/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 1:54 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Release the semaphore when exceptions are thrown as well. > > > This addresses bug SQOOP-674. > https://issues.apache.org/jira/browse/SQOOP-674 > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > 38e2292 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8657/diff/ > > > Testing > ------- > > Added unit tests to test this and a few other cases. > > > Thanks, > > Hari Shreedharan > >
