-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8892/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added missing method and one missing public inner class.


This addresses bug SQOOP-818.
    https://issues.apache.org/jira/browse/SQOOP-818


Diffs
-----

  src/java/com/cloudera/sqoop/manager/ExportJobContext.java 552f346 
  src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java dba4a49 

Diff: https://reviews.apache.org/r/8892/diff/


Testing
-------

* SQOOP-820 is needed in order to properly test this
* I've verified on ThirdParty tests that the connector is working using 
following command:

ant clean test '-Dtestcase=SQLServerManager*' 
-Dsqoop.test.sqlserver.connectstring.host_url=jdbc:sqlserver://<IP>:1433 
-Dsqoop.test.msserver.connector.factory=com.microsoft.sqoop.SqlServer.MSSQLServerManagerFactory

Please note that 2 test are expected to fail as they are testing custom schema 
support that Connector from Microsoft do not have at the moment, namely:

* SQLServerManagerExportManualTest.testExportCustomSchema()
* SQLServerManagerImportManualTest.testImportDifferentSchema()


Thanks,

Jarek Cecho

Reply via email to