----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8891/#review15147 -----------------------------------------------------------
Ship it! LGTM. I will run unit test and commit it. Thanks! - Cheolsoo Park On Jan. 8, 2013, 3:18 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8891/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2013, 3:18 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've added new method to ConnManager that will return boolean value to see if > Sqoop common code should automatically escape table on export. This method > returns false by default. > > > This addresses bug SQOOP-820. > https://issues.apache.org/jira/browse/SQOOP-820 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/ConnManager.java 21eea93 > src/java/org/apache/sqoop/manager/PostgresqlManager.java 7e6284e > src/java/org/apache/sqoop/manager/SQLServerManager.java 0c39599 > src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java 7c52110 > > Diff: https://reviews.apache.org/r/8891/diff/ > > > Testing > ------- > > * Unit tests seems to be passing > * I've verified using PostgreSQL and Microsoft SQL Server third party tests > that this change will not break custom schema support introduced in SQOOP-601 > and SQOOP-540. > > > Thanks, > > Jarek Cecho > >
