----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8685/#review15230 -----------------------------------------------------------
Ship it! Hi Sean, I do have just few small notes to your patch. Please feel free to fix them and upload your patch directly to JIRA (without another round on review board). src/docs/man/common-args.txt <https://reviews.apache.org/r/8685/#comment32846> Can we keep in the parameter list also the original --hadoop-home and just say that it's deprecated? src/docs/user/help.txt <https://reviews.apache.org/r/8685/#comment32845> Can we keep in the parameter list also the original --hadoop-home and just say that it's deprecated? src/docs/user/tools.txt <https://reviews.apache.org/r/8685/#comment32843> Would you mind changing reference from Cloudera to BigTop? src/docs/user/tools.txt <https://reviews.apache.org/r/8685/#comment32844> Can we keep in the parameter list also the original --hadoop-home and just say that it's deprecated? Jarcec - Jarek Cecho On Jan. 9, 2013, 5:39 p.m., Sean Mackrory wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8685/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 5:39 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > See JIRA for full description of the problem and solution. > > > This addresses bug SQOOP-796. > https://issues.apache.org/jira/browse/SQOOP-796 > > > Diffs > ----- > > bin/configure-sqoop ee1dd7b > bin/sqoop bc69083 > conf/sqoop-env-template.sh 0294f17 > src/docs/man/common-args.txt 129f5d1 > src/docs/man/sqoop.txt 44b4f4e > src/docs/user/common-args.txt 7c69886 > src/docs/user/help.txt 11b4f0c > src/docs/user/tools.txt ce83a24 > src/java/org/apache/sqoop/SqoopOptions.java 3e0ec3e > src/java/org/apache/sqoop/orm/CompilationManager.java 26adcbf > src/java/org/apache/sqoop/tool/BaseSqoopTool.java c0221c9 > src/scripts/run-perftest.sh 2a4ba21 > > Diff: https://reviews.apache.org/r/8685/diff/ > > > Testing > ------- > > Performed an import from MySQL on a pre-YARN MapReduce cluster (with > HADOOP_HOME set) and a YARN cluster (with HADOOP_COMMON_HOME and > HADOOP_MAPRED_HOME set). Although the YARN cluster failed, it appears to be > after Sqoop has located all of it's dependencies and that the problem is with > my YARN setup. > > > Thanks, > > Sean Mackrory > >
