----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8848/#review15591 -----------------------------------------------------------
Is it possible to add tests for enum type? It looks like the current test doesn't cover enum type. common/src/main/java/org/apache/sqoop/model/FormUtils.java <https://reviews.apache.org/r/8848/#comment33680> Why can't we just do "(Integer)jsonInputs.get(inputName)"? Does this introduce loss of precision? common/src/main/java/org/apache/sqoop/model/FormUtils.java <https://reviews.apache.org/r/8848/#comment33675> Shouldn't this be "type.isEnum()"? - Cheolsoo Park On Jan. 6, 2013, 5:58 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8848/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 5:58 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've fix methods toJson and fillValues() to work with new schema of > configuration objects. > > > This addresses bug SQOOP-812. > https://issues.apache.org/jira/browse/SQOOP-812 > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02e > common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45 > > Diff: https://reviews.apache.org/r/8848/diff/ > > > Testing > ------- > > I've added new unit test. > > > Thanks, > > Jarek Cecho > >
