----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8851/#review15594 -----------------------------------------------------------
Ship it! I will commit it after running tests. - Cheolsoo Park On Jan. 6, 2013, 6:16 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8851/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 6:16 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've removed moving configuration properties into connector context. > > > This addresses bug SQOOP-814. > https://issues.apache.org/jira/browse/SQOOP-814 > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java > 09056d3 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java > 2b0ed00 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java > ec047b4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java > c3ecdda > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java > 781c7f2 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java > 2313e65 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java > bf3c5e2 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java > 168e572 > > Diff: https://reviews.apache.org/r/8851/diff/ > > > Testing > ------- > > Unit tests are passing, tested on real cluster. > > > Thanks, > > Jarek Cecho > >
