----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9058/#review15603 -----------------------------------------------------------
Hi Venkat, Thank you very much for fixing this. I've noticed that couple of lines are ending with whitespace character. Would you mind removing those? Jarcec src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java <https://reviews.apache.org/r/9058/#comment33697> Nit: Trailing white space characters. src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java <https://reviews.apache.org/r/9058/#comment33698> Nit: Trailing white space characters. src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java <https://reviews.apache.org/r/9058/#comment33699> Nit: Trailing white space characters. src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java <https://reviews.apache.org/r/9058/#comment33700> Nit: Trailing white space characters. - Jarek Cecho On Jan. 22, 2013, 11:29 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9058/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 11:29 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > Fix generics usage so that the classes have right generics declarations - > Otherwise, some of the classees show up with errors when using eclipse > > > This addresses bug SQOOP-840. > https://issues.apache.org/jira/browse/SQOOP-840 > > > Diffs > ----- > > src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b > src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844 > src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d > src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java > 1b39519 > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java > f47d475 > > Diff: https://reviews.apache.org/r/9058/diff/ > > > Testing > ------- > > Ran all existing unit tests - No new functionality added so no new tests > > > Thanks, > > Venkat Ranganathan > >
