[
https://issues.apache.org/jira/browse/SQOOP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560844#comment-13560844
]
Jarek Jarcec Cecho commented on SQOOP-841:
------------------------------------------
Hi Venkat,
thank you very much for your opinion. I'm glad that you agree with my proposal!
I was planning to subclass the managers in tests to spoof out the functionality
and having the constructor to private might prohibit me doing that. However I
have to agree that having the constructor and setInstance() method public is
not the best approach either :-/
Jarcec
> Sqoop2: Remove final keyword from manager classes
> -------------------------------------------------
>
> Key: SQOOP-841
> URL: https://issues.apache.org/jira/browse/SQOOP-841
> Project: Sqoop
> Issue Type: Improvement
> Affects Versions: 1.99.1
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Trivial
> Fix For: 1.99.2
>
> Attachments: bugSQOOP-841.patch
>
>
> I've made all manager classes final in SQOOP-618 and consequently made them
> singleton objects in SQOOP-802. I believe that the final keyword is no longer
> required. Removing it will also simplify testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
