----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9167/#review15905 -----------------------------------------------------------
Ship it! Hi Jarcec +1 It is a good catch and the fix looks good. Should the Interruptedexception be ignored? I know it is not part of this JIRA, but I am wondering we should log for that also. I can create another JIRA if you think it needs to be separate from this to caught and thrown an exception when we hit the InterruptedException when waiting for the process to end - Venkat Ranganathan On Jan. 30, 2013, 11:39 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9167/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2013, 11:39 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've added check of the return value. > > > This addresses bug SQOOP-854. > https://issues.apache.org/jira/browse/SQOOP-854 > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java > 14d064a51725b23fe79990df8288554b4a22556a > > Diff: https://reviews.apache.org/r/9167/diff/ > > > Testing > ------- > > Tested on real cluster. > > > Thanks, > > Jarek Cecho > >
