-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9070/
-----------------------------------------------------------

(Updated Jan. 31, 2013, 4:37 p.m.)


Review request for Sqoop.


Changes
-------

I've incorporated Cheolsoo's suggestions.


Description
-------

I've improved the validator and move there some logic that was in initializer.


This addresses bug SQOOP-845.
    https://issues.apache.org/jira/browse/SQOOP-845


Diffs (updated)
-----

  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
 531dd2e9b7215bd1d3825fe7018b10d32e774db5 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
 c6336fabbdc2074206c31c541c5dfc2c0cb3d908 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
 5ba1aae12e457c70e2b8fdc6d530a8ee0b8be421 

Diff: https://reviews.apache.org/r/9070/diff/


Testing
-------

Unit tests seems to be passing and I tried simple import on real cluster.


Thanks,

Jarek Cecho

Reply via email to