----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9273/#review16041 -----------------------------------------------------------
Ship it! Hi Vasanth, thank you very much for taking a look at this. Your changes looks good to me, so Ship It! I've noticed that you've already upload the patch to JIRA, so I'll commit it shortly. Jarcec - Jarek Cecho On Feb. 2, 2013, 8:56 p.m., vasanthkumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9273/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 8:56 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Added extra argument to list table command. Initially it was getting only > public schema. With --schema arugment will retrieve tables of given schema. > Example: > sqoop list-tables --connect jdbc:postgresql://<host>/sqoop --username sqoop > --password sqoop -- --schema foo > > > This addresses bug sqoop-853. > https://issues.apache.org/jira/browse/sqoop-853 > > > Diffs > ----- > > src/docs/user/list-tables.txt 2d00237 > src/java/org/apache/sqoop/tool/ListTablesTool.java 529df37 > > Diff: https://reviews.apache.org/r/9273/diff/ > > > Testing > ------- > > > Thanks, > > vasanthkumar > >
