----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9488/#review16951 -----------------------------------------------------------
Looks good to me. New options are added. Can you please update docs? src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java <https://reviews.apache.org/r/9488/#comment35926> Can you be consistent with using "this" to keep the code clean? Thanks! - Cheolsoo Park On Feb. 18, 2013, 3:04 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9488/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 3:04 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've provided extra options that will override the build-in defaults if > needed. > > > This addresses bug SQOOP-901. > https://issues.apache.org/jira/browse/SQOOP-901 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java > a05bf606dbc61cfab4fc977fa1f51feb59c5e446 > src/java/org/apache/sqoop/manager/PostgresqlManager.java > facdc742f9bc2470b89b5bcac8b210bef84d7349 > src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java > ee00c4124b0a24fdc99142005be2f0b2d404d030 > > Diff: https://reviews.apache.org/r/9488/diff/ > > > Testing > ------- > > New unit test provided. > > > Thanks, > > Jarek Cecho > >
