> On Feb. 24, 2013, 10:16 p.m., Jarek Cecho wrote: > > src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java, line 17 > > <https://reviews.apache.org/r/9543/diff/1/?file=260691#file260691line17> > > > > I'm not sure that you want to have your private IP publicly available > > in the source code. > > Venkat Ranganathan wrote: > Fixed in second revision. But will create a new combo patch
Sorry, the comment was for previous issue. This is a non-routable private IP so security issue is not a concern, but still I understand your point and have fixed it in latest revision - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9543/#review17010 ----------------------------------------------------------- On Feb. 25, 2013, 10:02 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9543/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 10:02 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > This addresses SQOOP-846 (provide a Netezza connector) > > > This addresses bug SQOOP-846. > https://issues.apache.org/jira/browse/SQOOP-846 > > > Diffs > ----- > > src/java/org/apache/sqoop/lib/DelimiterSet.java 4e9bcab > src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 54eb258 > src/java/org/apache/sqoop/manager/DirectNetezzaManager.java PRE-CREATION > src/java/org/apache/sqoop/manager/MySQLUtils.java ef18818 > src/java/org/apache/sqoop/manager/NetezzaManager.java PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaDBDataSliceSplitter.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaDataDrivenDBInputFormat.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportJob.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportJob.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableInputFormat.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableInputSplitter.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableRecordExportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableTextExportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaJDBCStatementRunner.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/NetezzaTestUtils.java PRE-CREATION > > Diff: https://reviews.apache.org/r/9543/diff/ > > > Testing > ------- > > Ran all sqoop tests. Ran Netezza manual tests against Netezza VMs version 6 > and 7 > > > Thanks, > > Venkat Ranganathan > >
