> On March 14, 2013, 4:30 a.m., Jarek Cecho wrote: > > Hi Venkatesh, > > thank you for updating the patch. I have just two small nits. I'll take a > > few days to see if I'll be able to think of a way to crack it. I'll go > > ahead and commit it in case that I won't find any issues. > >
Thanks for your time Jarek. Will update the patch after incorporating your comments. > On March 14, 2013, 4:30 a.m., Jarek Cecho wrote: > > src/docs/user/connecting.txt, lines 63-70 > > <https://reviews.apache.org/r/9771/diff/2/?file=270255#file270255line63> > > > > Technically speaking the parameter -P is the most secure way of > > entering password, right? It's not stored anywhere and thus it can't leak > > in any way. Well, a file under user's home dir with 400 permissions is also secure but I see your point. Anyway you enter password, its stored in the credential store and cant be seen in job conf. > On March 14, 2013, 4:30 a.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/SqoopOptions.java, line 596 > > <https://reviews.apache.org/r/9771/diff/2/?file=270258#file270258line596> > > > > Can we put "return" after this statement? Good catch. - Seetharam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9771/#review17850 ----------------------------------------------------------- On March 13, 2013, 9:41 p.m., Seetharam Venkatesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9771/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 9:41 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > An attempt to add a way for users to pass credentials to sqoop in a secure > way by storing the password in a file under user's home directory with 400 > permissions. > > > This addresses bug https://issues.apache.org/jira/browse/SQOOP-914. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-914 > > > Diffs > ----- > > src/docs/man/common-args.txt cf9c0c3 > src/docs/user/common-args.txt 0554f81 > src/docs/user/connecting.txt 44a5111 > src/docs/user/help.txt 24fbddc > src/docs/user/tools.txt 96bf777 > src/java/org/apache/sqoop/SqoopOptions.java addc889 > src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java d270bc8 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 684d4a5 > src/java/org/apache/sqoop/util/CredentialsUtil.java PRE-CREATION > src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9771/diff/ > > > Testing > ------- > > Adds unit tests. All unit tests pass and checkstyle issues fixed. > > > Thanks, > > Seetharam Venkatesh > >
