----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9669/#review17987 -----------------------------------------------------------
Hi Vasanth, thank you for your quick feedback. I do have one final nit and I'm ready to commit it! client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java <https://reviews.apache.org/r/9669/#comment38005> Can we rename the function to just "print" to match the others? Jarcec - Jarek Cecho On March 15, 2013, 6:12 a.m., vasanthkumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9669/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 6:12 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Move string constants from FormDisplayer to resource file > > > This addresses bug SQOOP-887. > https://issues.apache.org/jira/browse/SQOOP-887 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/core/Constants.java ae3f994 > client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java > 8c133f2 > client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java > abd9643 > client/src/main/resources/client-resource.properties c3a22bb > > Diff: https://reviews.apache.org/r/9669/diff/ > > > Testing > ------- > > Done > > > Thanks, > > vasanthkumar > >
