----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9692/#review18044 -----------------------------------------------------------
Ship it! Thank you Vasanth for working on this. I've done few tests on real cluster to verify the functionality and everything seems to be working just fine. I've noticed that you've even fixed reporting of exported rows, so thank you! Jarcec - Jarek Cecho On March 1, 2013, 9:43 a.m., vasanthkumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9692/ > ----------------------------------------------------------- > > (Updated March 1, 2013, 9:43 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Merge HdfsSequenceExportExtractor and HdfsTextExportExtractor to one > HdfsExportExtractor > > > This addresses bug SQOOP-783. > https://issues.apache.org/jira/browse/SQOOP-783 > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > b201a8d > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportExtractor.java > PRE-CREATION > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java > 2280828 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java > ae419ff > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java > fae6573 > > Diff: https://reviews.apache.org/r/9692/diff/ > > > Testing > ------- > > Passing all tests. > > > Thanks, > > vasanthkumar > >
