----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10055/#review18234 -----------------------------------------------------------
Hi Ahmed, would you mind removing trailing white space characters? - Jarek Cecho On March 20, 2013, 11:56 p.m., Ahmed El Baz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10055/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 11:56 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > A patch implementing the Windows version of Sqoop run scripts. The scripts > follow the same logic as there .sh counterparts. > One difference is to create a Jar which references all classpath elements in > its Manifest, and provide that jar as the single jar needed for Sqoop. The > reason here is that in some cases if the number of classpath elements is > large, HADOOP_CLASSPATH gets very long which causes failures in Windows since > there is a limit to command lines. > As a workaround, I added a step to wrap all jars in the classpath in a single > jar, and then use that generated jar (this is also done in hadoop for Windows > to handle similar issues) > I did this in a utility script "BuildJar" which can be used for other > components as well. > This change is specific to Windows scripts, Linux scripts are not affected. > > > This addresses bug SQOOP-954. > https://issues.apache.org/jira/browse/SQOOP-954 > > > Diffs > ----- > > bin/BuildJar.ps1 PRE-CREATION > bin/configure-sqoop.cmd PRE-CREATION > bin/sqoop.cmd PRE-CREATION > conf/sqoop-env-template.cmd PRE-CREATION > > Diff: https://reviews.apache.org/r/10055/diff/ > > > Testing > ------- > > > Thanks, > > Ahmed El Baz > >
