----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9911/#review18316 -----------------------------------------------------------
Ship it! Looks good to me, thank you Abe! Jarcec - Jarek Cecho On March 19, 2013, 10:28 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9911/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 10:28 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Description > ------- > > commit 4e294831ca2ab0b20e5f2dd16017b7ca28b4d0db > Author: Abraham Elmahrek <[email protected]> > Date: Wed Mar 13 14:51:06 2013 -0700 > > SQOOP-941 Do not send sensitive values from server to client > > Remove sensitive string values from metadata sent to clients. > Add sensitivity filter (boolean parameter) when extracting forms. > > :100644 100644 57486b1... a69e009... M > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > :100644 100644 499ebeb... 55ba9db... M > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > :100644 100644 dbc0f93... b4e986a... M > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java > :100644 100644 601040d... cbe049a... M > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java > :100644 100644 4e07b6c... ad4753b... M > common/src/main/java/org/apache/sqoop/json/FrameworkBean.java > :100644 100644 a16c06e... a830646... M > common/src/main/java/org/apache/sqoop/json/JobBean.java > :100644 100644 074a579... 8189259... M > common/src/main/java/org/apache/sqoop/json/JsonBean.java > :100644 100644 9d8011b... 1ef72eb... M > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java > :100644 100644 4bb0ffc... 86b637a... M > common/src/main/java/org/apache/sqoop/json/ThrowableBean.java > :100644 100644 747a228... fd36825... M > common/src/main/java/org/apache/sqoop/json/ValidationBean.java > :100644 100644 c37b2cc... 029a776... M > common/src/main/java/org/apache/sqoop/json/VersionBean.java > :100644 100644 8b40a54... 3f8f985... M > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > :100644 100644 1322dd3... 58b7cbe... M > common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java > :100644 100644 38cdb7e... e078474... M > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java > :100644 100644 5aa581b... 5cc110a... M > common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java > :100644 100644 3ea30ce... 6af1d8b... M > common/src/test/java/org/apache/sqoop/json/TestJobBean.java > :100644 100644 7c77db6... 6ee9aa1... M > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java > :100644 100644 88267d1... 0cf0651... M > common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java > :100644 100644 7dab5a4... b88d7a4... M > common/src/test/java/org/apache/sqoop/json/TestUtil.java > :100644 100644 ebcb749... 95ea6e1... M > common/src/test/java/org/apache/sqoop/json/TestValidationBean.java > :100644 100644 dc0764e... 896c605... M > server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java > > > This addresses bug SQOOP-941. > https://issues.apache.org/jira/browse/SQOOP-941 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java > 57486b146f45235ea5a75cabec861da4c38672c4 > client/src/main/java/org/apache/sqoop/client/request/JobRequest.java > 499ebebc64e0d306f199b6729e49fdffed604382 > common/src/main/java/org/apache/sqoop/json/ConnectionBean.java > dbc0f935bfbe7c164c79f51a49f5704f31a309a2 > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java > 601040dced830fdd5509eb3d7f47f8b0ba535ac6 > common/src/main/java/org/apache/sqoop/json/FrameworkBean.java > 4e07b6cd77b48ff58df9210da43adba82fd492d3 > common/src/main/java/org/apache/sqoop/json/JobBean.java > a16c06e2177d7e1dacd05976d91f4484a8957ea4 > common/src/main/java/org/apache/sqoop/json/JsonBean.java > 074a5796135f32c7d3e03f2223601e50b8b628ba > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java > 9d8011bee92519e74c0a2813e3ddd108615390dd > common/src/main/java/org/apache/sqoop/json/ThrowableBean.java > 4bb0ffc39be0b648d8270400b5348f74f333c0fb > common/src/main/java/org/apache/sqoop/json/ValidationBean.java > 747a228084e0079a1c687226cfaecfc6b7ba61bb > common/src/main/java/org/apache/sqoop/json/VersionBean.java > c37b2cca53ce41c2594759838b16f43390f78841 > common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java > 8b40a547e230793a922cb97dd7f7031cb3e94712 > common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java > 1322dd3d64f072f9a93d9ef5bfccbfb9aff0556b > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java > 38cdb7e1d97ac4a7c53cb7e13184bb8433b06874 > common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java > 5aa581bb3f0a4542352a47e27bc1eb53acb955ce > common/src/test/java/org/apache/sqoop/json/TestJobBean.java > 3ea30cea6b1a175092645b8c2951045f8465df92 > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java > 7c77db6b6c746a5010a21fa4b92311706e553992 > common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java > 88267d1a730089adf6b72fb38afce61c13d25858 > common/src/test/java/org/apache/sqoop/json/TestUtil.java > 7dab5a468322245bb92384ec180066efd5b3c1c3 > common/src/test/java/org/apache/sqoop/json/TestValidationBean.java > ebcb7492219dcab580f351f330b4eb7cbc277f35 > server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java > dc0764e927289a1b9979a2a7bff08cbb019f6618 > > Diff: https://reviews.apache.org/r/9911/diff/ > > > Testing > ------- > > Updated unit tests and ran all unit tests. > > > Thanks, > > Abraham Elmahrek > >
