> On March 23, 2013, 11:21 p.m., Kathleen Ting wrote:
> > Ship It!

Thanks Jarcec for the contribution.


- Kathleen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9721/#review18321
-----------------------------------------------------------


On March 3, 2013, 5:15 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9721/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 5:15 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've decided to use the standard way of dealing with dependencies in Maven. 
> I've made both Oracle and Microsoft SQL Server JDBC drivers as dependencies 
> in a special profiles that must be enabled on command line. This way the 
> normal build will pass as they won't be included. If you user want to use 
> them, he needs to install them into local maven cache first. I've provided 
> instructions in pom file and I'll describe everything on Dev Guide once we 
> will have it.
> 
> 
> This addresses bug SQOOP-909.
>     https://issues.apache.org/jira/browse/SQOOP-909
> 
> 
> Diffs
> -----
> 
>   pom.xml 0620d086fdea73f5629f2fb86414573c5f54df17 
>   test/pom.xml 26aa556ca2cb486c92d7f03b801aa1e3532e6bdc 
>   test/src/main/java/org/apache/sqoop/test/db/OracleProvider.java 
> PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.java 
> PRE-CREATION 
>   
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java
>  567ddbcff598d3b281f15cb337da83fab901c867 
> 
> Diff: https://reviews.apache.org/r/9721/diff/
> 
> 
> Testing
> -------
> 
> To use Oracle provider run:
> 
> mvn clean integration-test 
> -Dsqoop.provider.class=org.apache.sqoop.test.db.OracleProvider -Djdbc.oracle 
> -Dhadoop.profile=200 
> -Dsqoop.provider.oracle.jdbc=jdbc:oracle:thin:@//oracle/xe
> 
> To use Sql Server provider run:
> 
> mvn clean integration-test 
> -Dsqoop.provider.class=org.apache.sqoop.test.db.SqlServerProvider 
> -Djdbc.sqlserver -Dhadoop.profile=200 
> -Dsqoop.provider.sqlserver.jdbc="jdbc:sqlserver://sqlserver"
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Reply via email to