-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10100/#review18375
-----------------------------------------------------------



client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
<https://reviews.apache.org/r/10100/#comment38583>

    line.getArgs().length >= 1?



client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
<https://reviews.apache.org/r/10100/#comment38582>

    line.getArgs().length >= 1?



client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
<https://reviews.apache.org/r/10100/#comment38584>

    line.getArgs().length >= 1?



client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
<https://reviews.apache.org/r/10100/#comment38585>

    line.getArgs().length >= 1?



client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/10100/#comment38580>

    protected final String?


- Abraham Elmahrek


On March 24, 2013, 8:46 p.m., vasanthkumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10100/
> -----------------------------------------------------------
> 
> (Updated March 24, 2013, 8:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> There is no help option for shell command's functions. Introducing the help 
> argument for functions.
> 
> 
> This addresses bug sqoop-965.
>     https://issues.apache.org/jira/browse/sqoop-965
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java cc80df1 
>   
> client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
>  0538901 
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 
> 6f62813 
>   
> client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
>  5bf9aaa 
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 
> f5155d5 
>   
> client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
>  18d3a70 
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 
> 736be20 
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 
> 9414b7d 
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 
> 1c85592 
>   
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
>  4fe20c1 
>   
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 
> 19a8123 
>   
> client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 
> d37b73a 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 
> 5505d51 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 
> 890ede1 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java 
> 110f67e 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java 
> 1038116 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java 
> bf26761 
>   
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
>  cefe0a2 
>   
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
>  48db8ab 
>   
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
>  8291a54 
>   
> client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
>  95ada63 
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 
> 3f0ac7d 
>   client/src/main/resources/client-resource.properties 734333e 
>   docs/src/site/sphinx/CommandLineClient.rst 1b9676f 
> 
> Diff: https://reviews.apache.org/r/10100/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> vasanthkumar
> 
>

Reply via email to