----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10332/#review19132 -----------------------------------------------------------
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java <https://reviews.apache.org/r/10332/#comment39684> Hi Venkat, thank you very much for your review. The FormUtils call is actually a parameter for method call from previous line, so I've put extra indent on purpose. - Jarek Cecho On April 8, 2013, 1:11 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10332/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 1:11 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've used mapreduce credentials cache to store the configuration objects > similarly as we did in SQOOP-914. > > > This addresses bug SQOOP-895. > https://issues.apache.org/jira/browse/SQOOP-895 > > > Diffs > ----- > > execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java > e16a2c4 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java > 4aa2128 > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 77f30ea > > Diff: https://reviews.apache.org/r/10332/diff/ > > > Testing > ------- > > Unit and integration tests seems to be passing. I've also verified the > changes on real cluster. > > > Thanks, > > Jarek Cecho > >
