-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10452/#review19135
-----------------------------------------------------------

Ship it!


Neat usage of string literal equals method :).

- Abraham Elmahrek


On April 14, 2013, 5:39 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10452/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 5:39 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added local job runner detection to the mapreduce submission engine.
> 
> 
> This addresses bug SQOOP-986.
>     https://issues.apache.org/jira/browse/SQOOP-986
> 
> 
> Diffs
> -----
> 
>   
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
>  77f30ea3b4172217c3e7c40aa4adfee87c754427 
> 
> Diff: https://reviews.apache.org/r/10452/diff/
> 
> 
> Testing
> -------
> 
> Integration tests seems to be passing in both hadoop profiles (100, 200) and 
> I've also tried running this patch on real hadoop clusters (both 1.x and 2.x).
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Reply via email to