----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10208/#review19196 -----------------------------------------------------------
Ship it! Ship It! - Kathleen Ting On March 31, 2013, 3:06 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10208/ > ----------------------------------------------------------- > > (Updated March 31, 2013, 3:06 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've provided implementation of caching various non-volatile objects in > client API. > > > This addresses bug SQOOP-647. > https://issues.apache.org/jira/browse/SQOOP-647 > > > Diffs > ----- > > client/pom.xml 0d14460905d5ace65f09b9d8563812dc76be1525 > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > 232ef20fb93b518ce67f09438de53e2d10a7a872 > > client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java > 19a81239fd78c0fc63b17d2fc118909f8da771d0 > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java > PRE-CREATION > pom.xml 25dfba6cbf839f5139dec93c10cf746434847acf > > Diff: https://reviews.apache.org/r/10208/diff/ > > > Testing > ------- > > I've added mockito library and provided tests for all methods that are using > caching. All unit and integration tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
