----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10731/#review19586 -----------------------------------------------------------
Ship it! It looks good. This should catch any cause of exception irrespective of the underlying behavior - Venkat Ranganathan On April 23, 2013, 4:03 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10731/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 4:03 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've changed expectation of IOException to just an Exception. > > > This addresses bug SQOOP-1008. > https://issues.apache.org/jira/browse/SQOOP-1008 > > > Diffs > ----- > > src/test/com/cloudera/sqoop/orm/TestClassWriter.java > 6158fb438babc967f28702301619807e9e0a9c3c > > Diff: https://reviews.apache.org/r/10731/diff/ > > > Testing > ------- > > The test seems to be passing on both JDK6 and JDK7. > > > Thanks, > > Jarek Cecho > >
