----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10749/#review19745 -----------------------------------------------------------
Ship it! Looks good except for some comments that need to be replaced. +1 test/src/main/java/org/apache/sqoop/test/db/TeradataProvider.java <https://reviews.apache.org/r/10749/#comment40746> Replace with teradata information. - Abraham Elmahrek On April 24, 2013, 2:24 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10749/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 2:24 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've added testing provider for Teradata database. > > > This addresses bug SQOOP-1009. > https://issues.apache.org/jira/browse/SQOOP-1009 > > > Diffs > ----- > > pom.xml 0abbb18442ce92a95168a8c4056fce910bdada19 > test/pom.xml 58f1c498199ac07db23867a0c95567d8dbb0d2ac > test/src/main/java/org/apache/sqoop/test/db/TeradataProvider.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java > c7998a17f6e092609270fec7d6dab5c886b76e87 > > test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java > 837a1aae6e803a10e3fbb8e88d8e3cf36455479a > > Diff: https://reviews.apache.org/r/10749/diff/ > > > Testing > ------- > > Integration tests seems to be passing: > > mvn integration-test -Dhadoop.profile=200 -Djdbc.teradata > -Dsqoop.provider.class=org.apache.sqoop.test.db.TeradataProvider > -Dsqoop.provider.teradata.jdbc=jdbc:teradata://$HOST/DATABASE=sqoop > -Dsqoop.provider.teradata.username=sqoop > -Dsqoop.provider.teradata.password=sqoop > > > Thanks, > > Jarek Cecho > >
