----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10869/#review20042 -----------------------------------------------------------
Hi Vasanth, thank you very much for working on this JIRA. client/src/main/java/org/apache/sqoop/client/SqoopClient.java <https://reviews.apache.org/r/10869/#comment41296> What about rather then creating one method that can do both synchronous and asynchronous job submission create method startSubmission(long jid) for synchronous mode and startSubmission(long jid, callback, long polltime) for asynchronous mode? I think that there is no need for the Long object, I would personally require caller to specify a poll period if synchronous mode is required. I would also like to expose callback that will be called every poll period with updated MSubmission object so that user code can react on that. We can easily reuse such callback in client shell to print out updated status. Jarcec - Jarek Cecho On April 30, 2013, 7:56 p.m., vasanthkumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10869/ > ----------------------------------------------------------- > > (Updated April 30, 2013, 7:56 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Synchronous job submission to Client API. > > > This addresses bug SQOOP-985. > https://issues.apache.org/jira/browse/SQOOP-985 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java f9137bb > > client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java > f68ac11 > docs/src/site/sphinx/ClientAPI.rst a9d39fb > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java > adcfbaf > > Diff: https://reviews.apache.org/r/10869/diff/ > > > Testing > ------- > > Done > > > Thanks, > > vasanthkumar > >
